Amar3tto commented on code in PR #22584:
URL: https://github.com/apache/beam/pull/22584#discussion_r982571836
##########
sdks/java/io/cdap/build.gradle:
##########
@@ -52,14 +52,17 @@ dependencies {
implementation library.java.cdap_plugin_zendesk
implementation library.java.commons_lang3
implementation library.java.guava
+ implementation library.java.google_code_gson
implementation library.java.hadoop_common
implementation library.java.hadoop_mapreduce_client_core
implementation library.java.jackson_core
implementation library.java.jackson_databind
implementation library.java.slf4j_api
+ implementation library.java.spark_streaming
Review Comment:
@mosche What do you mean by naming scheme?
Do you suggest to add something like this?
```
def shouldProvideSpark2 = true
def shouldProvideSpark3 = false
```
...
```
if (shouldProvideSpark2) {
implementation library.java.spark_streaming
implementation library.java.spark_core
}
if (shouldProvideSpark3) {
implementation library.java.spark3_streaming
implementation library.java.spark3_core
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
