mosche commented on issue #23206:
URL: https://github.com/apache/beam/issues/23206#issuecomment-1263716233

   Thinking this through, I fear this feature cannot be supported. The 
resulting behavior would be very inconsistent and even more confusing.
   
   Let's imagine there's optional support for a `profileName` field when 
serializing `ProfileCredentialsProvider`. It cannot be required, that would be 
backwards incompatible.
   
   If we provide the options as CLI args it works as expected for both 
alternatives:
   - Use the given profile on the worker
      ```
      --awsCredentialsProvider={"@type": "ProfileCredentialsProvider, 
"profileName":"myprofile"}
     ```
   - Use the default profile as configured on the respective worker where we 
load credentials
     ```
      --awsCredentialsProvider={"@type": "ProfileCredentialsProvider"}
      ```   
   Unfortunately this would NOT be consistent with a programmatic usage :/
   -  Use the given profile on the worker
      ```
      ProfileCredentialsProvider.create("myprofile")
      ```  
   - Use the default profile as configured on the machine where the DAG is 
generated and tell the worker to use that profile as well :/ This is due to the 
fact how the provider is initialized and when serializing the provider we don't 
know if it was explicitly provided or not.
      ```
      ProfileCredentialsProvider.create()
      ```  
   
   Any objections closing the ticket?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to