johnjcasey commented on PR #23234: URL: https://github.com/apache/beam/pull/23234#issuecomment-1263808562
> All nits in the current review. > > Since we are returning a ScheduledExecutorService now for GcsOptions#getExecutorService, do we not get test failures anymore (e.g. RemoteExecutionTest)? > > In a follow-up can you migrate all usages of GcsOptions#getExecutorService to ExecutorOptions#getScheduledExecutorService? I don't think we can do this, because if someone is using GcsOptions#setExecutorService, this change could break them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
