alexeyinkin commented on code in PR #23417: URL: https://github.com/apache/beam/pull/23417#discussion_r985438062
########## learning/tour-of-beam/frontend/lib/repositories/models/group.dart: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import 'package:json_annotation/json_annotation.dart'; + +import 'node.dart'; + +part 'group.g.dart'; Review Comment: That link shows `json_serializable`'s own examples, and they are version-controlled as an example for the people to see what is generated. In practice, it is rare useful to version-control generated files because: - They can accidentally get behind their originals or get edited manually. Then mere fixing the generation may break the project. See https://github.com/apache/beam/issues/21925 - They make diffs larger. In our particular setting this adds a burden of maintaining the Apache license comments in those files because it gets deleted all the time, and it was painful with Playground generated test mocks until we got rid of those files in the repository. To set if off, we can add an exception for `./gradlew rat`, but that just adds things to maintain. We aim to eliminate generated files from version control. We are almost done with this on the frontend with the only controlled files are gRPC protobuf artifacts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
