tvalentyn commented on issue #23511: URL: https://github.com/apache/beam/issues/23511#issuecomment-1269118603
I think there is no concern adding public CombineFn implementations to `__all__`. Re second approach - there may be some ambiguity here for composite combiners. For example: would there be an expectation for defining "Top.SmallestPerKey.combineFn" or just Top.combineFn ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
