piotr-szuberski commented on a change in pull request #12023: URL: https://github.com/apache/beam/pull/12023#discussion_r447604523
########## File path: sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py ########## @@ -0,0 +1,138 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +# pytype: skip-file + +from __future__ import absolute_import + +import logging +import typing +import unittest + +from past.builtins import unicode + +import apache_beam as beam +from apache_beam import coders +from apache_beam.io.external.jdbc import WriteToJdbc +from apache_beam.testing.test_pipeline import TestPipeline + +# pylint: disable=wrong-import-order, wrong-import-position, ungrouped-imports +try: + import sqlalchemy +except ImportError: + sqlalchemy = None +# pylint: enable=wrong-import-order, wrong-import-position, ungrouped-imports + +# pylint: disable=wrong-import-order, wrong-import-position, ungrouped-imports +try: + from testcontainers.postgres import PostgresContainer +except ImportError: + PostgresContainer = None +# pylint: enable=wrong-import-order, wrong-import-position, ungrouped-imports + +JdbcTestRow = typing.NamedTuple( + "JdbcTestRow", + [ + ("f_id", int), + ("f_real", float), + ("f_string", unicode), + ], +) + +coders.registry.register_coder(JdbcTestRow, coders.RowCoder) + + +@unittest.skipIf(sqlalchemy is None, "sql alchemy package is not installed.") +@unittest.skipIf( + PostgresContainer is None, "testcontainers package is not installed") Review comment: Is it ok if the tests will run for python >=3.5 only? testcontainers don't support python2, as well as pytest-postgresql. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
