mosche commented on code in PR #22584:
URL: https://github.com/apache/beam/pull/22584#discussion_r988739446
##########
sdks/java/io/cdap/build.gradle:
##########
@@ -52,14 +52,17 @@ dependencies {
implementation library.java.cdap_plugin_zendesk
implementation library.java.commons_lang3
implementation library.java.guava
+ implementation library.java.google_code_gson
implementation library.java.hadoop_common
implementation library.java.hadoop_mapreduce_client_core
implementation library.java.jackson_core
implementation library.java.jackson_databind
implementation library.java.slf4j_api
+ implementation library.java.spark_streaming
Review Comment:
Hmm, I personally don't see why it's necessary to repeat the same mistake
just because it was made once?
Also IOs and runners are very different in nature. Replacing the runner is
trivial, but with the Cdap IO you're better aware right from the start that it
depends on Spark 2 (and Spark 3 is not (yet) supported).
In any case, I don't wanna block this PR ... just a long hanging fruit and
missed opportunity in my eyes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
