PhilippeMoussalli commented on PR #23498: URL: https://github.com/apache/beam/pull/23498#issuecomment-1270196323
> The diff won't render so I can't leave comments inline on the notebook unfortunately. Mostly, this LGTM, my only comments are: > > 1. In the Model handlers section > > > The key is used o keep a reference > > Should be `The key is used to keep a reference > > 2. Could you please add the comment about issue #21863 to CLIPWrapper and PytorchNoBatchModelHandlerKeyedTensor > 3. Could you please fix the whitespace precommit violations and resolve the merge conflicts? > > @yeandy I know you had thoughts about using cascade vs ensemble, does that look right in this PR? Also feel free to drop in other comments of course :) thanks for reviewing @damccorm. I resolved the issues mentioned above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
