phoerious commented on code in PR #16658:
URL: https://github.com/apache/beam/pull/16658#discussion_r991660368
##########
sdks/python/container/boot.go:
##########
@@ -73,13 +74,20 @@ const (
)
func main() {
+ if err := mainError(); err != nil {
+ log.Print(err)
+ os.Exit(1)
Review Comment:
I answered this somewhere above and it's commented in the code. log.Fatal
prevents clean-up of resources, so we cannot shut down the Python worker
process cleanly. Without this change, you will end up producing a lot of
un-wait()-ed zombie processes and potentially leave temporary files in place
etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
