Abacn commented on PR #23557: URL: https://github.com/apache/beam/pull/23557#issuecomment-1273913235
One thing I notice is that the removed `bigquery_tools.BigQueryReader` class is a documented one ([documentation](https://beam.apache.org/releases/pydoc/current/apache_beam.io.gcp.bigquery_tools.html#apache_beam.io.gcp.bigquery_tools.BigQueryReader)) and never marked as deprecated, although classes using it were marked as deprecated (`bigquery._BigQuerySource` and `bigquery.BigQueryReader`). `bigquery_tools.py` also had no doctoring warning the module was for internal usage only. I would recommend we mark `bigquery_tools.BigQueryReader` class as deprecated for now, and remove it and its tests in a future version (after upcoming 2.43.0). The changes in `bigquery.py` and its tests look good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
