rvballada commented on PR #17163:
URL: https://github.com/apache/beam/pull/17163#issuecomment-1274265458
Hello Lukasz ;
It is ready for another review.
I have one question:
* The expand method now returns a WriteJmsResult,
* WriteJmsResult keeps the messages in error thanks to:
private final TupleTag<EventT> failedMessageTag;
private final PCollection<EventT> failedMessages;
And the expand method:
@Override
public Map<TupleTag<?>, PValue> expand() {
return ImmutableMap.of(failedMessageTag, failedMessages);
}
Should this method be consumed somewhere or can we keep it like this?
Regards
Vincent BALLADA
De : Lukasz Cwik ***@***.***>
Date : jeudi, 7 avril 2022 à 19:40
À : apache/beam ***@***.***>
Cc : BALLADA Vincent ***@***.***>, Author ***@***.***>
Objet : Re: [apache/beam] [BEAM-13608] JmsIO dynamic topics feature (PR
#17163)
[vwP6KQExYeP8ewAAAAASUVORK5CYII=]
[EXT]
Is this ready for another review?
—
Reply to this email directly, view it on
GitHub<https://github.com/apache/beam/pull/17163#issuecomment-1092018841>, or
unsubscribe<https://github.com/notifications/unsubscribe-auth/AUR22HDN7DNGRBPFQJTVPGLVD4MX3ANCNFSM5RNJCQCA>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
Confidential C
-- Disclaimer ------------------------------------
Ce message ainsi que les eventuelles pieces jointes constituent une
correspondance privee et confidentielle a l'attention exclusive du destinataire
designe ci-dessus. Si vous n'etes pas le destinataire du present message ou une
personne susceptible de pouvoir le lui delivrer, il vous est signifie que toute
divulgation, distribution ou copie de cette transmission est strictement
interdite. Si vous avez recu ce message par erreur, nous vous remercions d'en
informer l'expediteur par telephone ou de lui retourner le present message,
puis d'effacer immediatement ce message de votre systeme.
*** This e-mail and any attachments is a confidential correspondence
intended only for use of the individual or entity named above. If you are not
the intended recipient or the agent responsible for delivering the message to
the intended recipient, you are hereby notified that any disclosure,
distribution or copying of this communication is strictly prohibited. If you
have received this communication in error, please notify the sender by phone or
by replying this message, and then delete this message from your system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
