alexeyinkin commented on code in PR #23572:
URL: https://github.com/apache/beam/pull/23572#discussion_r992360366
##########
learning/tour-of-beam/frontend/lib/cache/sdk.dart:
##########
@@ -19,30 +19,30 @@
import 'dart:async';
import 'package:flutter/widgets.dart';
+import 'package:playground_components/playground_components.dart';
-import '../models/sdk.dart';
import '../repositories/client/client.dart';
import '../repositories/models/get_sdks_response.dart';
class SdkCache extends ChangeNotifier {
final TobClient client;
- final _sdks = <SdkModel>[];
+ final _sdks = <Sdk>[];
Review Comment:
We made a separate `SdkModel` here to be received from the ToB backend, and
later learned we can reuse `Sdk` from the shared package by just adding one
more deserialization to it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
