n3lsok commented on a change in pull request #11405:
URL: https://github.com/apache/beam/pull/11405#discussion_r448014725
##########
File path:
sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java
##########
@@ -123,8 +123,24 @@ public static Read read() {
* Like {@link #read()} but executes multiple instances of the Redis query
substituting each
* element of a {@link PCollection} as key pattern.
*/
- public static ReadAll readAll() {
- return new AutoValue_RedisIO_ReadAll.Builder()
+ public static ReadKeyPatterns readKeyPatterns() {
+ return new AutoValue_RedisIO_ReadKeyPatterns.Builder()
+ .setConnectionConfiguration(RedisConnectionConfiguration.create())
+ .setBatchSize(1000)
+ .setOutputParallelization(true)
+ .build();
+ }
+
+ /**
+ * Like {@link #read()} but executes multiple instances of the Redis query
substituting each
+ * element of a {@link PCollection} as key pattern.
+ *
+ * @deprecated This method is not consistent with the readAll pattern of
other transforms and will
+ * be remove soon. Please update you code to use {@link
#readKeyPatterns()} instead.
+ */
+ @Deprecated
+ public static ReadKeyPatterns readAll() {
Review comment:
Hello! how can I to use this version ?? I cant' see how to compile and
to use with an development which I have problems using RedisIO.readAll(), as I
see this versión solved this issue. Please your help, All the best!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
