tvalentyn commented on code in PR #23587:
URL: https://github.com/apache/beam/pull/23587#discussion_r992904132
##########
sdks/python/build-requirements.txt:
##########
@@ -22,6 +22,7 @@ wheel>=0.36.0
grpcio-tools==1.37.0
mypy-protobuf==1.18
+protobuf==3.19.4
Review Comment:
this can cause mismatches between protobuf at job submission time and
startup time.. I wonder if we exclude broken versions just for MacOS?
##########
sdks/python/setup.py:
##########
@@ -336,7 +336,12 @@ def get_portability_package_data():
'azure-storage-blob >=12.3.2',
'azure-core >=1.7.0',
],
- 'dataframe': ['pandas>=1.0,<1.5']
+ #(TODO): Some tests using Pandas implicitly calls inspect.stack()
+ # with python 3.10 leading to incorrect stacktrace.
+ # This can be removed on dill is updated to version >= 0.3.5.1
Review Comment:
to confirm, 0.3.5.1 (already released version) has the fix?
##########
sdks/python/test-suites/gradle.properties:
##########
@@ -21,28 +21,30 @@
# And if you want to use multiple versions, concat them with comma and no
whitespace.
# dataflow test-suites
-dataflow_precommit_it_task_py_versions=3.7,3.9
+# (TODO): https://github.com/apache/beam/issues/21971
+# Add python 3.10 to dataflow test-suites
+dataflow_precommit_it_task_py_versions=3.7,3.9,3.10
dataflow_mongodbio_it_task_py_versions=3.7
dataflow_chicago_taxi_example_task_py_versions=3.7
-dataflow_validates_runner_batch_tests=3.7,3.9
-dataflow_validates_runner_streaming_tests=3.7,3.8,3.9
-dataflow_validates_container_tests=3.7,3.8,3.9
+dataflow_validates_runner_batch_tests=3.7,3.9,3.10
+dataflow_validates_runner_streaming_tests=3.8,3.9,3.10
Review Comment:
i'd make these 3.7,3.10 (lowest+highest).
##########
sdks/python/test-suites/gradle.properties:
##########
@@ -21,28 +21,30 @@
# And if you want to use multiple versions, concat them with comma and no
whitespace.
# dataflow test-suites
-dataflow_precommit_it_task_py_versions=3.7,3.9
+# (TODO): https://github.com/apache/beam/issues/21971
+# Add python 3.10 to dataflow test-suites
+dataflow_precommit_it_task_py_versions=3.7,3.9,3.10
dataflow_mongodbio_it_task_py_versions=3.7
dataflow_chicago_taxi_example_task_py_versions=3.7
-dataflow_validates_runner_batch_tests=3.7,3.9
-dataflow_validates_runner_streaming_tests=3.7,3.8,3.9
-dataflow_validates_container_tests=3.7,3.8,3.9
+dataflow_validates_runner_batch_tests=3.7,3.9,3.10
Review Comment:
i'd make these 3.7,3.10 (lowest+highest).
##########
sdks/python/test-suites/gradle.properties:
##########
@@ -21,28 +21,30 @@
# And if you want to use multiple versions, concat them with comma and no
whitespace.
# dataflow test-suites
-dataflow_precommit_it_task_py_versions=3.7,3.9
+# (TODO): https://github.com/apache/beam/issues/21971
+# Add python 3.10 to dataflow test-suites
+dataflow_precommit_it_task_py_versions=3.7,3.9,3.10
dataflow_mongodbio_it_task_py_versions=3.7
dataflow_chicago_taxi_example_task_py_versions=3.7
-dataflow_validates_runner_batch_tests=3.7,3.9
-dataflow_validates_runner_streaming_tests=3.7,3.8,3.9
-dataflow_validates_container_tests=3.7,3.8,3.9
+dataflow_validates_runner_batch_tests=3.7,3.9,3.10
+dataflow_validates_runner_streaming_tests=3.8,3.9,3.10
+dataflow_validates_container_tests=3.7,3.8,3.9,3.10
# TODO: Enable following tests after making sure we have enough capacity.
-dataflow_validates_runner_batch_tests_V2=3.9
-dataflow_validates_runner_streaming_tests_V2=3.9
-dataflow_examples_postcommit_py_versions=3.9
+dataflow_validates_runner_batch_tests_V2=3.10
+dataflow_validates_runner_streaming_tests_V2=3.10
+dataflow_examples_postcommit_py_versions=3.10
# direct runner test-suites
-direct_mongodbio_it_task_py_versions=3.9
-direct_examples_postcommit_py_versions=3.7,3.8,3.9
+direct_mongodbio_it_task_py_versions=3.10
+direct_examples_postcommit_py_versions=3.7,3.8,3.9,3.10
# flink runner test-suites
-flink_validates_runner_precommit_py_versions=3.9
-flink_validates_runner_postcommit_py_versions=3.7,3.8,3.9
-flink_examples_postcommit_py_versions=3.7,3.9
+flink_validates_runner_precommit_py_versions=3.10
+flink_validates_runner_postcommit_py_versions=3.8,3.9,3.10
Review Comment:
i'd make these 3.7,3.10 (lowest+highest).
##########
sdks/python/test-suites/gradle.properties:
##########
@@ -21,28 +21,30 @@
# And if you want to use multiple versions, concat them with comma and no
whitespace.
# dataflow test-suites
-dataflow_precommit_it_task_py_versions=3.7,3.9
+# (TODO): https://github.com/apache/beam/issues/21971
+# Add python 3.10 to dataflow test-suites
+dataflow_precommit_it_task_py_versions=3.7,3.9,3.10
dataflow_mongodbio_it_task_py_versions=3.7
dataflow_chicago_taxi_example_task_py_versions=3.7
-dataflow_validates_runner_batch_tests=3.7,3.9
-dataflow_validates_runner_streaming_tests=3.7,3.8,3.9
-dataflow_validates_container_tests=3.7,3.8,3.9
+dataflow_validates_runner_batch_tests=3.7,3.9,3.10
+dataflow_validates_runner_streaming_tests=3.8,3.9,3.10
+dataflow_validates_container_tests=3.7,3.8,3.9,3.10
# TODO: Enable following tests after making sure we have enough capacity.
-dataflow_validates_runner_batch_tests_V2=3.9
-dataflow_validates_runner_streaming_tests_V2=3.9
-dataflow_examples_postcommit_py_versions=3.9
+dataflow_validates_runner_batch_tests_V2=3.10
+dataflow_validates_runner_streaming_tests_V2=3.10
+dataflow_examples_postcommit_py_versions=3.10
# direct runner test-suites
-direct_mongodbio_it_task_py_versions=3.9
-direct_examples_postcommit_py_versions=3.7,3.8,3.9
+direct_mongodbio_it_task_py_versions=3.10
+direct_examples_postcommit_py_versions=3.7,3.8,3.9,3.10
# flink runner test-suites
-flink_validates_runner_precommit_py_versions=3.9
-flink_validates_runner_postcommit_py_versions=3.7,3.8,3.9
-flink_examples_postcommit_py_versions=3.7,3.9
+flink_validates_runner_precommit_py_versions=3.10
+flink_validates_runner_postcommit_py_versions=3.8,3.9,3.10
+flink_examples_postcommit_py_versions=3.7,3.10
# samza runner test-suites
-samza_validates_runner_postcommit_py_versions=3.7,3.8,3.9
+samza_validates_runner_postcommit_py_versions=3.8,3.9,3.10
Review Comment:
i'd make these 3.7,3.10 (lowest+highest).
##########
sdks/python/test-suites/gradle.properties:
##########
@@ -21,28 +21,30 @@
# And if you want to use multiple versions, concat them with comma and no
whitespace.
# dataflow test-suites
-dataflow_precommit_it_task_py_versions=3.7,3.9
+# (TODO): https://github.com/apache/beam/issues/21971
+# Add python 3.10 to dataflow test-suites
+dataflow_precommit_it_task_py_versions=3.7,3.9,3.10
Review Comment:
i'd make these 3.7,3.10 (lowest+highest).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
