damccorm commented on code in PR #23088:
URL: https://github.com/apache/beam/pull/23088#discussion_r993705916
##########
playground/infrastructure/helper.py:
##########
@@ -112,24 +113,27 @@ def find_examples(work_dir: str, supported_categories:
List[str],
"""
has_error = False
examples = []
- for root, _, files in os.walk(work_dir):
- for filename in files:
- filepath = os.path.join(root, filename)
- error_during_check_file = _check_file(
- examples=examples,
- filename=filename,
- filepath=filepath,
- supported_categories=supported_categories,
- sdk=sdk)
- has_error = has_error or error_during_check_file
+ for subdir in subdirs:
Review Comment:
Technically this probably doesn't handle situations like `abc/def` is a
parent of `./abc/def/ghi` (and other relative path cases). Otherwise, this
seems reasonable; maybe we can just convert everything to PurePaths before
sorting and then sort by parents?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
