tvalentyn commented on code in PR #23586:
URL: https://github.com/apache/beam/pull/23586#discussion_r993963040
##########
sdks/python/test-suites/dataflow/common.gradle:
##########
@@ -22,6 +22,9 @@ enablePythonPerformanceTest()
String pythonVersionSuffix = project.ext.pythonVersion
? "-py${project.ext.pythonVersion.replace('.', '')}"
: ''
+// Python versions to run secondary integration tests.
+// Should set to each minimum supported minor version.
+def runItDfSecondaryVersions = ['3.7']
Review Comment:
We already have a couple of places where we configure python versions:
https://github.com/apache/beam/blob/master/sdks/python/test-suites/gradle.properties
https://github.com/apache/beam/blob/master/.test-infra/jenkins/PythonTestProperties.groovy
I'd prefer not to add yet another place.
I think the fix should be separating IO tests into a separate suite.
@MarcoRob and team are looking into migrating to GH Actions and if I understand
the plan, they are sharding the tests into separate suites as part of that
effort.
IO GCP would become a separate suite, is that correct, @MarcoRob ?
@Abacn if we need to break it down further now may be a good time to provide
feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
