agvdndor commented on code in PR #23094: URL: https://github.com/apache/beam/pull/23094#discussion_r994534503
########## sdks/python/apache_beam/examples/ml-orchestration/kfp/components/ingestion/component.yaml: ########## @@ -0,0 +1,36 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Ingestion +description: Component that mimicks scraping data from the web and outputs it to a jsonlines format file +inputs: + - name: base_artifact_path + description: base path to store data + type: String +outputs: + - name: ingested_dataset_path + description: target uri for the ingested dataset + type: String +implementation: + container: + image: <your-docker-registry/ingestion-image-name:latest> Review Comment: This should indeed be modified by the user. As far as I'm aware that's not possible for component definitions in `.yaml` files without additional tooling. We could switch to using an independent templating engine like [jinja](https://jinja.palletsprojects.com/en/3.1.x/). In that case, there will be jinja-specific syntax in both the `yaml` files and the `pipeline.py` file that loads the kfp components. I believe that would indeed make it easier to run the example itself, but might make the snippets in the website's documentation harder to understand since it introduces yet another tool. So I'm open to suggestion about how to tackle this trade-off! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
