olehborysevych commented on code in PR #23476: URL: https://github.com/apache/beam/pull/23476#discussion_r994540604
########## .github/workflows/playground_examples_ci.yml: ########## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Playground Examples CI + +on: + push: + paths: + - .github/workflows/playground* + - playground/backend/** + - playground/infrastructure/** + - learning/katas/** + - examples/** + - sdks/** Review Comment: lets change this to folders with examples ########## .github/workflows/playground_examples_ci.yml: ########## @@ -0,0 +1,43 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +name: Playground Examples CI + +on: + push: + paths: + - .github/workflows/playground* + - playground/backend/** + - playground/infrastructure/** + - learning/katas/** + - examples/** + - sdks/** Review Comment: @damccorm we think that example CI should also check not only examples that were added or modified, but also all examples when something is changed in sdk codebase. But since now we are checking examples with a fixed BEAM version we don't want to affect developers working on sdk code. We though that we might add some kind of a nightly examples check that will verify examples with latest sdk code. What do you think about this? ########## playground/infrastructure/grpc_client.py: ########## @@ -52,7 +54,7 @@ async def run_code( f'Incorrect sdk: must be from this pool: {", ".join(sdks)}') request = api_pb2.RunCodeRequest( code=code, sdk=sdk, pipeline_options=pipeline_options) - response = await self._stub.RunCode(request) + response = await self._stub.RunCode(request, timeout=self._timeout, wait_for_ready=self._wait_for_ready) Review Comment: cool thank you for clarification -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
