lukecwik commented on code in PR #23234:
URL: https://github.com/apache/beam/pull/23234#discussion_r996085918
##########
runners/google-cloud-dataflow-java/build.gradle:
##########
@@ -287,7 +287,8 @@ def buildAndPushDockerJavaContainer =
tasks.register("buildAndPushDockerJavaCont
commandLine "docker", "tag", "${defaultDockerImageName}",
"${dockerJavaImageName}"
}
exec {
- commandLine "gcloud", "docker", "--", "push", "${dockerJavaImageName}"
+// commandLine "gcloud", "docker", "--", "push", "${dockerJavaImageName}"
Review Comment:
is this necessary?
##########
sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/options/GcsOptions.java:
##########
@@ -132,14 +131,7 @@ public interface GcsOptions extends
ApplicationNameOptions, GcpOptions, Pipeline
class ExecutorServiceFactory implements DefaultValueFactory<ExecutorService>
{
@Override
public ExecutorService create(PipelineOptions options) {
- /* The SDK requires an unbounded thread pool because a step may create X
writers
- * each requiring their own thread to perform the writes otherwise a
writer may
- * block causing deadlock for the step because the writers buffer is
full.
- * Also, the MapTaskExecutor launches the steps in reverse order and
completes
- * them in forward order thus requiring enough threads so that each
step's writers
- * can be active.
- */
Review Comment:
Move this comment into ScheduledExecutorServiceFactory just above `new
UnboundedScheduledExecutorService()`
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/ExecutorOptions.java:
##########
@@ -19,10 +19,7 @@
import com.fasterxml.jackson.annotation.JsonIgnore;
import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.ScheduledThreadPoolExecutor;
-import java.util.concurrent.TimeUnit;
-import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.util.concurrent.MoreExecutors;
-import
org.apache.beam.vendor.guava.v26_0_jre.com.google.common.util.concurrent.ThreadFactoryBuilder;
+import org.apache.beam.sdk.util.UnboundedScheduledExecutorService;
public interface ExecutorOptions extends PipelineOptions {
Review Comment:
comment and `@Description` needs to be updated since the core pool size is
irrelevant now.
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/options/ExecutorOptions.java:
##########
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.options;
+
+import com.fasterxml.jackson.annotation.JsonIgnore;
+import java.util.concurrent.ScheduledExecutorService;
+import org.apache.beam.sdk.util.UnboundedScheduledExecutorService;
+
+public interface ExecutorOptions extends PipelineOptions {
Review Comment:
class comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
