aromanenko-dev commented on code in PR #23603:
URL: https://github.com/apache/beam/pull/23603#discussion_r998316151
##########
runners/spark/2/build.gradle:
##########
@@ -19,8 +19,8 @@
def basePath = '..'
/* All properties required for loading the Spark build script */
project.ext {
- // Set the version of all Spark-related dependencies here.
- spark_version = '2.4.8'
+ // Spark 2 version as defined in BeamModulePlugin
+ spark_version = spark2_version
Review Comment:
As a side note - it's ambiguous to have two types of the naming style
(underscore and camel case) in the same config file.
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -499,6 +499,10 @@ class BeamModulePlugin implements Plugin<Project> {
def arrow_version = "5.0.0"
def jmh_version = "1.34"
+ // Export Spark versions, so they are defined in a single place only
+ project.ext.spark2_version = spark2_version
Review Comment:
nit: just worth to mention that spark 2 is deprecated in Beam
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
