TheNeuralBit commented on pull request #12136: URL: https://github.com/apache/beam/pull/12136#issuecomment-652625495
> Are we sure that gcp.pubsub.PubsubMessage is right and it is Dataflow that is wrong? There's also PubsubClient, which checks for null in getAttributeMap: https://github.com/apache/beam/blob/master/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubClient.java#L330 I think for this reason a null attribute map will crash a pipeline running on Dataflow, but not on any other runner. Really we should just be consistent between PubsubClient and PubsubSink (Datflow). I think it will be better to make Dataflow more permissive, rather than changing PubsubClient and possibly breaking non-Dataflow users. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
