ibzib commented on a change in pull request #12157:
URL: https://github.com/apache/beam/pull/12157#discussion_r448656410
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/SparkPipelineRunner.java
##########
@@ -40,9 +41,7 @@
import org.apache.beam.runners.jobsubmission.PortablePipelineRunner;
import org.apache.beam.runners.spark.aggregators.AggregatorsAccumulator;
import org.apache.beam.runners.spark.metrics.MetricsAccumulator;
-import
org.apache.beam.runners.spark.translation.SparkBatchPortablePipelineTranslator;
-import org.apache.beam.runners.spark.translation.SparkContextFactory;
-import org.apache.beam.runners.spark.translation.SparkTranslationContext;
+import org.apache.beam.runners.spark.translation.*;
Review comment:
Import classes instead of packages to avoid bloating the namespace.
##########
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkTranslationContext.java
##########
@@ -35,15 +35,15 @@
* compute them after translation.
*/
public class SparkTranslationContext {
- private final JavaSparkContext jsc;
+ protected final JavaSparkContext jsc;
Review comment:
Why are these access changes necessary?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
