AnandInguva commented on code in PR #23642:
URL: https://github.com/apache/beam/pull/23642#discussion_r1003619237
##########
sdks/python/apache_beam/ml/inference/sklearn_inference.py:
##########
@@ -156,7 +174,8 @@ class
SklearnModelHandlerPandas(ModelHandler[pandas.DataFrame,
def __init__(
self,
model_uri: str,
- model_file_type: ModelFileType = ModelFileType.PICKLE):
+ model_file_type: ModelFileType = ModelFileType.PICKLE,
+ inference_fn: Optional[Callable[[BaseEstimator,
Sequence[pandas.DataFrame], Optional[Dict[str, Any]]], Any]] =
_default_pandas_inference_fn):
Review Comment:
Hm..I haven't seen it in the codebase AFAIK. it's a PEP proposed feature
https://peps.python.org/pep-3102/ so maybe we can use it? @tvalentyn what do
you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
