olehborysevych commented on code in PR #23782:
URL: https://github.com/apache/beam/pull/23782#discussion_r1004409778
##########
.github/workflows/tour_of_beam_backend_integration.yml:
##########
@@ -57,19 +64,9 @@ jobs:
# pin to the biggest Go version supported by Cloud Functions runtime
go-version: '1.16'
- # 1. Datastore emulator
- - name: 'Set up Cloud SDK'
- uses: 'google-github-actions/setup-gcloud@v0'
- with:
- version: 397.0.0
- project_id: ${{ env.DATASTORE_PROJECT_ID }}
- install_components: 'beta,cloud-datastore-emulator'
- - name: 'Start datastore emulator'
- run: |
- gcloud beta emulators datastore start \
- --data-dir=${{ env.DATASTORE_EMULATOR_DATADIR }} \
- --host-port=${{ env.DATASTORE_EMULATOR_HOST }} \
- --consistency=1 &
+ # 1. Start emulators
+ - name: Start emulators
+ run: docker-compose up -d
Review Comment:
do we need to wait some time before emulator containers are fully
functional? we can add health checks directly to docker-compose if needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
