lostluck commented on PR #23814: URL: https://github.com/apache/beam/pull/23814#issuecomment-1290829498
The Go team doesn't even support versions of Go that are two versions old, we should be on at minimum Go1.18 or simply follow the latest version, go 1.19. The absolute lowest we should be is 1.16 which includes the ability to self install and download newer Go versions, which we take advantage of in our go infra for Beam. On Tue, Oct 25, 2022, 6:50 AM Danny McCormick ***@***.***> wrote: > ***@***.**** commented on this pull request. > > Could you please review this new workflow? We also kindly ask for your > help on the creation of the ASF infra ticket for the Token , unfortunately > the previous one created by us was closed for the following reason : Infra > cannot act on tickets submitted by people unaffiliated with the Foundation. > > Could you please link to the ticket? I assume this is asking for the > docker hub repo/token to be created? > > @lostluck <https://github.com/lostluck> could you help with a review here > as the most recent release manager? I'm not too familiar with our container > release flow/what makes sense here. > ------------------------------ > > In .github/workflows/publish_dockerhub_images.yml > <https://github.com/apache/beam/pull/23814#discussion_r1004509485>: > > > + steps: > + - name: Login to Docker Hub > + uses: ***@***.*** > + with: > + username: ${{secrets.DOCKER_HUB_REPO}} > + password: ${{secrets.DOCKER_HUB_TOKEN}} > + - name: Setting Release Branch > + run: echo "RC_TAG=v${{env.RELEASE_VERSION}}-RC${{github.event.inputs.RC_NUM}}" >> $GITHUB_ENV > + - name: Checkout > + uses: ***@***.*** > + with: > + ref: ${{env.RC_TAG}} > + - name: Setup Go > + uses: ***@***.*** > + with: > + go-version: '^1.13.1' > > This seems odd - why are we (a) starting with such a low version (b) > pinning to the minor version, vs using the standard action > <https://github.com/apache/beam/blob/master/.github/actions/setup-self-hosted-action/action.yml> > for grabbing our current supported versions > ------------------------------ > > In .github/workflows/publish_dockerhub_images.yml > <https://github.com/apache/beam/pull/23814#discussion_r1004511634>: > > > + java-version: | > + 8 > + 17 > + 11 > > Do we actually need all 3 versions of Java? Is there a reason they're > ordered like this (not 8, 11, 17)? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/23814#pullrequestreview-1154843030>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADKDOFK2QU436FB7XBNEIGTWE7QQRANCNFSM6AAAAAARNMC5DE> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
