TobKed commented on a change in pull request #12150:
URL: https://github.com/apache/beam/pull/12150#discussion_r448928301
##########
File path: release/src/main/scripts/build_release_candidate.sh
##########
@@ -170,26 +174,50 @@ if [[ $confirmation = "y" ]]; then
git clone ${GIT_REPO_URL}
cd ${BEAM_ROOT_DIR}
git checkout ${RELEASE_BRANCH}
+ git push origin "${RELEASE_BRANCH}"
+ RELEASE_COMMIT=$(git rev-parse --verify HEAD)
- echo '-------------------Generating Python Artifacts-----------------'
- cd sdks/python
- virtualenv ${LOCAL_PYTHON_VIRTUALENV}
+ echo '-------------------Creating Python Virtualenv-----------------'
+ python3 -m venv ${LOCAL_PYTHON_VIRTUALENV}
Review comment:
Thanks for pointing this out. I wasn't sure which python version I
should use, but since 2 is sunsetting I decided to use 3 . Now I am thinking is
using fstrings was the good idea since it requires 3.6+.
WDYT @tvalentyn ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
