tvalentyn commented on code in PR #23642:
URL: https://github.com/apache/beam/pull/23642#discussion_r1007455170
##########
sdks/python/apache_beam/ml/inference/sklearn_inference.py:
##########
@@ -156,7 +174,8 @@ class
SklearnModelHandlerPandas(ModelHandler[pandas.DataFrame,
def __init__(
self,
model_uri: str,
- model_file_type: ModelFileType = ModelFileType.PICKLE):
+ model_file_type: ModelFileType = ModelFileType.PICKLE,
+ inference_fn: Optional[Callable[[BaseEstimator,
Sequence[pandas.DataFrame], Optional[Dict[str, Any]]], Any]] =
_default_pandas_inference_fn):
Review Comment:
it is useful to make sure people don't use positional arguments if doing so
would be error-prone (for example for functions taking many args, or if you are
changing the order of the existing args).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
