KevinGG commented on code in PR #17367:
URL: https://github.com/apache/beam/pull/17367#discussion_r1008576994
##########
sdks/python/apache_beam/io/textio.py:
##########
@@ -675,7 +686,8 @@ def __init__(
escapechar=escapechar)
def expand(self, pvalue):
- return pvalue.pipeline | Read(self._source)
+ return pvalue.pipeline | Read(self._source).with_output_types(
+ self._source.output_type_hint())
Review Comment:
Just a note: this is a non-backward-compatible change and will break if the
user code sets `with_output_types` especially when it's an auto-generated Row
schema (for Beam >= v2.39.0, the fix on user-side is: users no longer need to
set `with_output_types`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
