lostluck commented on PR #23411: URL: https://github.com/apache/beam/pull/23411#issuecomment-1295756963
From a process perspective, feel free to review it and if it looks good to you, mark it as approved at which point i can merge it. Otherwise it'll wait till Monday. Alternatively you can patch the PR into your client and test your changes with that PR. But in any case way, it'll be reviewed and merged in on Monday (unless Ritesh is out sick or something). On Fri, Oct 28, 2022, 11:57 PM capthiron ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In sdks/go/pkg/beam/io/bigtableio/bigtable.go > <https://github.com/apache/beam/pull/23411#discussion_r1008649891>: > > > +import ( > + "context" > + "fmt" > + "hash/fnv" > + "reflect" > + > + "cloud.google.com/go/bigtable" > + "github.com/apache/beam/sdks/v2/go/pkg/beam" > + "github.com/apache/beam/sdks/v2/go/pkg/beam/register" > +) > + > +func init() { > + register.DoFn2x1[int, func(*Mutation) bool, error](&writeFn{}) > + register.Iter1[*Mutation]() > + register.DoFn2x1[int, func(*Mutation) bool, error](&writeBatchFn{}) > + register.Iter1[*Mutation]() > > So I will wait until #23890 <https://github.com/apache/beam/pull/23890> > is merged into master and then try testing with the generic registration > again? > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/beam/pull/23411#discussion_r1008649891>, or > unsubscribe > <https://github.com/notifications/unsubscribe-auth/ADKDOFIDAFAR2ODG32TKPNTWFTDG3ANCNFSM6AAAAAAQYH5KXM> > . > You are receiving this because you were mentioned.Message ID: > ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
