arne-alex commented on code in PR #23333:
URL: https://github.com/apache/beam/pull/23333#discussion_r1011639382
##########
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/StreamingDataflowWorker.java:
##########
@@ -1197,13 +1239,36 @@ public State getState() {
}
public void setState(State state) {
+ Instant now = clock.get();
Review Comment:
I've run two different pipelines that include this PR with Google Cloud
Profiler enabled. They spent 105µs out of 18.65s overall and 4.45ms out of
16.43s overall modifying/reading Work.State, respectively. This is a negligible
fraction of CPU time. If there's any at all, any performance regression would
be negligible, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
