olehborysevych commented on code in PR #23928: URL: https://github.com/apache/beam/pull/23928#discussion_r1011927760
########## backend-deploy-cloudbuild.yaml: ########## @@ -0,0 +1,38 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +steps: + # This step builds the base image for Beam Playground worker + - name: 'gcr.io/cloud-builders/docker' + args: + - 'build' + - '--tag=us-central1-docker.pkg.dev/$PROJECT_ID/$_ARTIFACT_REGISTRY_REPOSITORY_ID/backend-builder:worker' Review Comment: @MakarkinSAkvelon @ruslan-ikhsan Is it ok that we have this hardcoded? What if we are deploying playground to a different region? ########## playground/infrastructure/helm-playground/templates/service-router.yml: ########## @@ -0,0 +1,39 @@ + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: v1 +kind: Service +metadata: + labels: + app: backend-router + type: backend + name: playground-router + annotations: + cloud.google.com/backend-config: '{"default": "bkend-health"}' + cloud.google.com/neg: '{"ingress": true}' +spec: + ports: + - name: https + port: {{ .Values.service.port }} + protocol: TCP + targetPort: {{ .Values.service.targetPort }} + - name: redis Review Comment: @MakarkinSAkvelon this doesn't look consistent with other services. Why is it different from other services and needs a redis port explicitly? ########## playground/infrastructure/helm-playground/values.yaml: ########## @@ -0,0 +1,41 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +replicaCount: 1 +image: + java_image: beam_playground-backend-java + go_image: beam_playground-backend-go + router_image: beam_playground-backend-router + scio_image: beam_playground-backend-scio + python_image: beam_playground-backend-python + frontend_image: beam_playground-frontend + pullPolicy: Always +service: + type: NodePort + targetPort: 8080 + port: 443 +autoscaling: + enabled: false + minReplicas: 1 + maxReplicas: 4 + targetCPUUtilizationPercentage: 80 + +static_ip: 34.96.104.87 Review Comment: @MakarkinSAkvelon possibly we need to revert those changes? I don't like the idea of our test project names and ip's getting into beam repository. ########## playground/infrastructure/helm-playground/templates/deployment-frontend.yml: ########## @@ -0,0 +1,45 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +apiVersion: apps/v1 +kind: Deployment +metadata: + name: playground-frontend + labels: + app: backend-frontend + type: backend +spec: + template: + metadata: + name: playground + labels: + app: backend-frontend + type: backend + spec: + containers: + - name: playground-backend-frontend + image: "{{ .Values.registry}}/{{ .Values.image.frontend_image }}:{{ .Values.tag }}" + imagePullPolicy: {{ .Values.image.pullPolicy }} + ports: + - containerPort: 8080 + env: + - name: CACHE_TYPE Review Comment: @MakarkinSAkvelon playground frontend doesn't need redis ########## playground/terraform/applications/main.tf: ########## @@ -26,14 +26,14 @@ data "terraform_remote_state" "playground-state" { } } -module "default" { - source = "./default" - project_id = var.project_id - create_default_service = var.create_default_service -} +# module "default" { Review Comment: @MakarkinSAkvelon can we remove this ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
