purbanow commented on a change in pull request #12117:
URL: https://github.com/apache/beam/pull/12117#discussion_r450015267
##########
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeServiceImpl.java
##########
@@ -25,7 +27,9 @@
import java.util.function.Consumer;
import java.util.stream.Collectors;
import javax.sql.DataSource;
+import org.apache.beam.sdk.io.snowflake.data.SnowflakeTableSchema;
import org.apache.beam.sdk.io.snowflake.enums.CloudProvider;
Review comment:
For now, I would keep it outside of serviceImpl as its easier to see
which cloud providers currently are supported by IO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
