scwhittle commented on code in PR #23882:
URL: https://github.com/apache/beam/pull/23882#discussion_r1013884988
##########
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java:
##########
@@ -999,14 +1022,7 @@ public void onClaimFailed(PositionT position) {}
}
}
} finally {
Review Comment:
Oops, yes I didn't push.
If I understand correctly, in this particular case we are guaranteed that if
an exception escapes it will fail because it is the root. So leaving the code
as is. Let me know if there is something else you'd like changed in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
