jrmccluskey commented on code in PR #23642:
URL: https://github.com/apache/beam/pull/23642#discussion_r1014303486
##########
sdks/python/apache_beam/ml/inference/sklearn_inference.py:
##########
@@ -156,7 +174,8 @@ class
SklearnModelHandlerPandas(ModelHandler[pandas.DataFrame,
def __init__(
self,
model_uri: str,
- model_file_type: ModelFileType = ModelFileType.PICKLE):
+ model_file_type: ModelFileType = ModelFileType.PICKLE,
+ inference_fn: Optional[Callable[[BaseEstimator,
Sequence[pandas.DataFrame], Optional[Dict[str, Any]]], Any]] =
_default_pandas_inference_fn):
Review Comment:
I can drop in the single-star character into the constructor and see how it
looks. Shouldn't be a big change and helps make things explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
