Abacn commented on code in PR #23951:
URL: https://github.com/apache/beam/pull/23951#discussion_r1015754535
##########
sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py:
##########
@@ -385,7 +383,13 @@ def _prepare_runtime_metrics(self, distributions):
return runtime_in_s
-class ConsoleMetricsPublisher(object):
+class MetricsPublisher:
Review Comment:
work with type hint here
https://github.com/apache/beam/blob/560aa8d7b75fee87c0e7911ac19557c6f11838ae/sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py#L206
as publish method is invoked here
https://github.com/apache/beam/blob/560aa8d7b75fee87c0e7911ac19557c6f11838ae/sdks/python/apache_beam/testing/load_tests/load_test_metrics_utils.py#L236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
