robertwb commented on a change in pull request #12177:
URL: https://github.com/apache/beam/pull/12177#discussion_r450424896
##########
File path: sdks/python/setup.py
##########
@@ -168,6 +168,7 @@ def get_version():
# [BEAM-5628] Beam VCF IO is not supported in Python 3.
'pyvcf>=0.6.8,<0.7.0; python_version < "3.0"',
# fixes and additions have been made since typing 3.5
+ 'requests>=2.24.0',
Review comment:
Using the current version as the minimum bound is fine. Bound this above
at <3.0.
https://requests.readthedocs.io/en/master/dev/philosophy/#semantic-versioning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
