phoerious commented on code in PR #16658:
URL: https://github.com/apache/beam/pull/16658#discussion_r1016295330
##########
sdks/python/container/boot.go:
##########
@@ -73,13 +74,20 @@ const (
)
func main() {
+ if err := mainError(); err != nil {
+ log.Print(err)
+ os.Exit(1)
Review Comment:
I just don't like implicit logic like that. Maybe that's because I'm not a
Go programmer, but I was totally surprised to see a simple log print call to
hard-exit the main process. It is totally non-obvious and you have to read the
documentation to understand what's happening. This is not something one would
expect unless perhaps you are used to Go idiosyncrasies. I changed it to
log.Fatal() since you seem to prefer it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
