alexeyinkin commented on code in PR #24031:
URL: https://github.com/apache/beam/pull/24031#discussion_r1016780065
##########
playground/frontend/playground_components/lib/src/models/example_base.dart:
##########
@@ -48,32 +49,35 @@ extension ExampleTypeToString on ExampleType {
/// and other large fields.
/// These objects are fetched as lists from [ExampleRepository].
class ExampleBase with Comparable<ExampleBase>, EquatableMixin {
- final Sdk sdk;
- final List<String> tags;
- final ExampleType type;
- final String name;
- final String path;
- final String description;
+ final Complexity? complexity;
final int contextLine;
+ final String description;
final bool isMultiFile;
final String? link;
+ final String name;
+ final String path;
final String pipelineOptions;
- final Complexity complexity;
+ final Sdk sdk;
+ final List<String> tags;
+ final ExampleType type;
+ final ExampleViewOptions viewOptions;
const ExampleBase({
- required this.sdk,
required this.name,
required this.path,
- required this.description,
- required this.tags,
+ required this.sdk,
required this.type,
+ this.complexity,
this.contextLine = 1,
+ this.description = '',
this.isMultiFile = false,
this.link,
- required this.pipelineOptions,
- required this.complexity,
+ this.pipelineOptions = '',
+ this.tags = const [],
+ this.viewOptions = ExampleViewOptions.empty,
});
+ // TODO(alexeyinkin): Use all fields,
https://github.com/apache/beam/issues/23979
Review Comment:
This is because it is hard to look up all usages of the `operator ==`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
