lostluck commented on code in PR #16658:
URL: https://github.com/apache/beam/pull/16658#discussion_r1017270667
##########
sdks/python/container/boot.go:
##########
@@ -73,13 +74,20 @@ const (
)
func main() {
+ if err := mainError(); err != nil {
+ log.Print(err)
+ os.Exit(1)
Review Comment:
A fair point!
It's not a Go convention though, it's a logger convention. Though, through a
bit of research, it's clear that it's less common than I thought in the current
era. TIL!
It's common enough that [SLF4J has an FAQ for why they *don't* have
it.](https://www.slf4j.org/faq.html#fatal)
But I see that python pointedly [aliases CRITICAL as
FATAL](https://peps.python.org/pep-0282/#levels) and doesn't mandate that
termination outcome, which given the environment of most of the change, is
likely the context here.
And rust [doesn't have one either](https://docs.rs/log/latest/log/) .
Thank you for the discussion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
