Lizzfox commented on PR #23501: URL: https://github.com/apache/beam/pull/23501#issuecomment-1308841268
@johnjcasey @chamikaramj I would like to discuss the path to the package with CDAP IO examples. Initially, we pushed all the code into the `/examples/java/src/main/java/org/apache/beam/examples/complete/cdap` package, but then we started getting a dependency conflict during the JavaPreCommit PR checks. On October 24, the example package was migrated to Spark 3 (commit https://github.com/apache/beam/commit/760c83e94020971d84b904270b087d4c3d69fd00). Since we use Spark 2 dependency (from `SparkReceiverIO`) we get conflicts. To resolve this, we decided to move the cdap example to `/examples/java/cdap/` package, as it was done for the [twitter](https://github.com/apache/beam/tree/master/examples/java/twitter) example, and remove Spark Runner from the `build.gradle` (we do not support this runner in our solution). My question here is: is this solution to the issue acceptable? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
