AdalbertMemSQL commented on code in PR #23535: URL: https://github.com/apache/beam/pull/23535#discussion_r1018009823
########## sdks/java/io/singlestore/build.gradle: ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * License); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an AS IS BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +plugins { id 'org.apache.beam.module' } +applyJavaNature( + automaticModuleName: 'org.apache.beam.sdk.io.singlestore', +) +provideIntegrationTestingDependencies() +enableJavaPerformanceTesting() + +description = "Apache Beam :: SDKs :: Java :: IO :: SingleStore" +ext.summary = "IO to read and write on SingleStore datasource." + +dependencies { + implementation library.java.vendored_guava_26_0_jre + implementation library.java.joda_time + implementation project(path: ":sdks:java:core", configuration: "shadow") + implementation group: 'com.singlestore', name: 'singlestore-jdbc-client', version: '1.1.4' + implementation library.java.slf4j_api + implementation "org.apache.commons:commons-dbcp2:2.8.0" Review Comment: Do I understand correctly that your proposition is to add these libs to this map ``` // A map of maps containing common libraries used per language. To use: // dependencies { // compile library.java.slf4j_api // } project.ext.library = [ java : [ ``` and use it here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
