alexeyinkin commented on code in PR #23776: URL: https://github.com/apache/beam/pull/23776#discussion_r1019491637
########## learning/tour-of-beam/frontend/lib/pages/tour/widgets/stateless_expansion_tile.dart: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import 'package:flutter/material.dart'; +import 'package:playground_components/playground_components.dart'; + +import '../../../components/expansion_tile_wrapper.dart'; + +class StatelessExpansionTile extends StatelessWidget { + final bool isExpanded; + final void Function(bool)? onExpansionChanged; Review Comment: `final ValueChanged<bool>? onExpansionChanged;` ########## learning/tour-of-beam/frontend/lib/pages/tour/widgets/stateless_expansion_tile.dart: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import 'package:flutter/material.dart'; +import 'package:playground_components/playground_components.dart'; + +import '../../../components/expansion_tile_wrapper.dart'; + +class StatelessExpansionTile extends StatelessWidget { + final bool isExpanded; + final void Function(bool)? onExpansionChanged; + final Widget title; + final Widget child; + + const StatelessExpansionTile({ + required super.key, + required this.isExpanded, + required this.onExpansionChanged, + required this.title, + required this.child, + }); + + @override + Widget build(BuildContext context) { + return ExpansionTileWrapper( + ExpansionTile( + // TODO(nausharipov): isn't rebuilt without key. + key: key, Review Comment: `key: ValueKey(isExpanded)` Then there may be a case when we still need the key in this widget. Then we will invent a combination like `ValueKey('$key-$isExpanded')` or something like that. ########## learning/tour-of-beam/frontend/lib/pages/tour/widgets/stateless_expansion_tile.dart: ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import 'package:flutter/material.dart'; +import 'package:playground_components/playground_components.dart'; + +import '../../../components/expansion_tile_wrapper.dart'; + +class StatelessExpansionTile extends StatelessWidget { + final bool isExpanded; + final void Function(bool)? onExpansionChanged; + final Widget title; + final Widget child; + + const StatelessExpansionTile({ + required super.key, Review Comment: Delete this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
