amaliujia commented on a change in pull request #12169:
URL: https://github.com/apache/beam/pull/12169#discussion_r450517449
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/FilterScanConverter.java
##########
@@ -47,7 +46,7 @@ public RelNode convert(ResolvedFilterScan zetaNode,
List<RelNode> inputs) {
zetaNode.getFilterExpr(),
zetaNode.getInputScan().getColumnList(),
input.getRowType().getFieldList(),
- ImmutableMap.of());
+ context.getFunctionArgumentRefMapping());
Review comment:
I am planning to improve testing coverage in next steps and gradually
make necessary converters to use `getFunctionArgumentRefMapping`. E.g. in
project or join.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
