ibzib commented on a change in pull request #12169:
URL: https://github.com/apache/beam/pull/12169#discussion_r450527691
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ConversionContext.java
##########
@@ -62,4 +83,20 @@ RelOptCluster cluster() {
QueryTrait getTrait() {
return trait;
}
+
+ Map<List<String>, ResolvedNode> getSqlUDTVF() {
+ return sqlUDTVF;
+ }
+
+ Map<String, RexNode> getFunctionArgumentRefMapping() {
+ return functionArgumentRefMapping;
+ }
+
+ void addToFunctionArgumentRefMapping(String s, RexNode r) {
Review comment:
I was suggesting removing `addToFunctionArgumentRefMapping` and
`clearFunctionArgumentRefMapping` completely, and using only
`getFunctionArgumentRefMapping()` in other classes. But it's up to you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
