Abacn commented on PR #23535: URL: https://github.com/apache/beam/pull/23535#issuecomment-1312173844
Thanks! Will take a look. For now, could you please integrate Read.java and Write.java into SingleStoreIO.java, as the patterns used for other IO connectors (e.g. [JdbcIO](https://github.com/apache/beam/blob/master/sdks/java/io/jdbc/src/main/java/org/apache/beam/sdk/io/jdbc/JdbcIO.java)). It users may not able to do something like ``` import org.apache.beam.sdk.io.singlestore.Read; import org.apache.beam.sdk.io.singlestore.Write; ``` since there may be naming conflictions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
