rezarokni commented on a change in pull request #12175:
URL: https://github.com/apache/beam/pull/12175#discussion_r450542229
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java
##########
@@ -334,27 +335,27 @@ private ObjectMapper objectMapper() {
@AutoValue
public abstract static class ParseResult implements POutput {
- public abstract JsonToRowWithErrFn getJsonToRowWithErrFn();
+ abstract JsonToRowWithErrFn getJsonToRowWithErrFn();
- public abstract PCollection<Row> getParsedLine();
+ abstract PCollection<Row> getParsedLine();
- public abstract PCollection<Row> getFailedParse();
+ abstract PCollection<Row> getFailedParse();
Review comment:
There are two public methods:
https://github.com/apache/beam/pull/12175/files#diff-eef3983ed081455798dfacfa9251ff38L382
https://github.com/apache/beam/pull/12175/files#diff-eef3983ed081455798dfacfa9251ff38L393
That folks can use
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
