lostluck commented on code in PR #23285: URL: https://github.com/apache/beam/pull/23285#discussion_r1022224996
########## sdks/go/pkg/beam/io/spannerio/spanner_test.go: ########## @@ -0,0 +1,249 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. + +package spannerio + +import ( + "cloud.google.com/go/spanner" + "cloud.google.com/go/spanner/spannertest" + "cloud.google.com/go/spanner/spansql" + "context" + "github.com/apache/beam/sdks/v2/go/pkg/beam" + "github.com/apache/beam/sdks/v2/go/pkg/beam/testing/passert" + "github.com/apache/beam/sdks/v2/go/pkg/beam/testing/ptest" + "google.golang.org/api/iterator" + "google.golang.org/api/option" + "google.golang.org/grpc" + "reflect" + "testing" +) + +type TestDto struct { + One string `spanner:"One"` + Two int64 `spanner:"Two"` +} + +func TestColumnsFromStructReturnsColumns(t *testing.T) { + // arrange + // act + cols := columnsFromStruct(reflect.TypeOf(TestDto{})) + + // assert + if len(cols) != 2 { + t.Fatalf("got %v columns, expected 2", len(cols)) + } +} + +func TestRead(t *testing.T) { + testCases := []struct { + name string + database string + rows []TestDto + expectedError bool + }{ + { + name: "Successfully read 4 rows", + database: "projects/fake-proj/instances/fake-instance/databases/fake-db-4-rows", + rows: []TestDto{ + { + One: "one", + Two: 1, + }, + { + One: "one", + Two: 2, + }, + { + One: "one", + Two: 3, + }, + { + One: "one", + Two: 4, + }, + }, + }, + { + name: "Successfully read 1 rows", + database: "projects/fake-proj/instances/fake-instance/databases/fake-db-1-rows", + rows: []TestDto{ + { + One: "one", + Two: 1, + }, + }, + }, + } + + for _, testCase := range testCases { + t.Run(testCase.name, func(t *testing.T) { + srv, srvCleanup := newServer(t) + defer srvCleanup() + + client, cleanup := createFakeClient(t, srv.Addr, testCase.database) + defer cleanup() + + ddl, err := spansql.ParseDDL("", + `CREATE TABLE Test ( + One STRING(20), + Two INT64, + ) PRIMARY KEY (Two)`) + if err != nil { + t.Fatalf("Unable to create DDL statement for spanner test: %v", err) + } + + err = srv.UpdateDDL(ddl) + if err != nil { + t.Fatalf("Unable to run DDL into spanner db: %v", err) + } + + var mutations []*spanner.Mutation + for _, m := range testCase.rows { + mutation, err := spanner.InsertStruct("Test", m) + if err != nil { + t.Fatalf("Unable to create mutation to insert struct: %v", err) + } + + mutations = append(mutations, mutation) + } + + _, err = client.Apply(context.Background(), mutations) + if err != nil { + t.Fatalf("Applying mutations: %v", err) + } + + p := beam.NewPipeline() + s := p.Root() + rows := query(s, "", client, "SELECT * from Test", reflect.TypeOf(TestDto{})) + + passert.Count(s, rows, "", len(testCase.rows)) + ptest.RunAndValidate(t, p) + }) + } +} + +func TestWrite(t *testing.T) { + testCases := []struct { + name string + database string + rows []TestDto + expectedError bool + }{ + { + name: "Successfully write 4 rows", + database: "projects/fake-proj/instances/fake-instance/databases/fake-db-4-rows", + rows: []TestDto{ + { + One: "one", + Two: 1, + }, + { + One: "one", + Two: 2, + }, + { + One: "one", + Two: 3, + }, + { + One: "one", + Two: 4, + }, + }, + }, + } + + for _, testCase := range testCases { + t.Run(testCase.name, func(t *testing.T) { + srv, srvCleanup := newServer(t) + defer srvCleanup() + + client, cleanup := createFakeClient(t, srv.Addr, testCase.database) + defer cleanup() + + ddl, err := spansql.ParseDDL("", + `CREATE TABLE Test ( + One STRING(20), + Two INT64, + ) PRIMARY KEY (Two)`) + if err != nil { + t.Fatalf("Unable to create DDL statement for spanner test: %v", err) + } + + err = srv.UpdateDDL(ddl) + if err != nil { + t.Fatalf("Unable to run DDL into spanner db: %v", err) + } + + p, s, col := ptest.CreateList(testCase.rows) + + write(s, "", client, "Test", col) + + ptest.RunAndValidate(t, p) + + verifyClient, verifyClientCleanup := createFakeClient(t, srv.Addr, testCase.database) + defer verifyClientCleanup() + + stmt := spanner.Statement{SQL: "SELECT * FROM Test"} + it := verifyClient.Single().Query(context.Background(), stmt) Review Comment: Just commenting to confirm if the plan is to pass the client into an instance of writeFn (and queryFn above) and calling ProcessFn directly, so that code gets tested? As written, these test the basics of the fake. I know you're busy/working on this in your spare time, so this is probably your plan when you get a moment, but I'd rather make a comment, then accidentally ignore something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
