tvalentyn commented on code in PR #23870: URL: https://github.com/apache/beam/pull/23870#discussion_r1022323491
########## sdks/python/apache_beam/vendor/__init__.py: ########## @@ -0,0 +1,17 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + +"""Contains third party libraries supported by apache beam.""" Review Comment: supported by apache beam? ########## build.gradle.kts: ########## @@ -170,6 +170,9 @@ tasks.rat { // Ignore typesciript package management. "sdks/typescript/package-lock.json", "sdks/typescript/node_modules/**/*", + + // Ignore third party vendored files + "sdks/python/vendor/**/*", Review Comment: should this be `sdks/python/apache_beam/vendor/**/*` ? ########## sdks/python/scripts/run_pylint.sh: ########## @@ -64,6 +64,11 @@ while IFS= read -d $'\0' -r file ; do EXCLUDED_GENERATED_FILES+=("$file") done < <(find apache_beam/portability/api -type f -name "*pb2*.py" -print0) +# Ignore vendor files. +while IFS= read -d $'\0' -r file ; do + EXCLUDED_GENERATED_FILES+=("$file") Review Comment: this is no longer "generated files", let's pick a better name / new variable. ########## sdks/python/setup.py: ########## @@ -232,12 +232,8 @@ def get_portability_package_data(): # The issue was fixed in version 1.9.2.1 'crcmod>=1.7,<2.0', 'orjson<4.0', Review Comment: nit: let's move orjson below to make order alphabetical here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
