Abacn commented on code in PR #23535: URL: https://github.com/apache/beam/pull/23535#discussion_r1023138062
########## CHANGES.md: ########## @@ -60,6 +60,7 @@ * Support for Bigtable sink (Write and WriteBatch) added (Go) ([#23324](https://github.com/apache/beam/issues/23324)). * S3 implementation of the Beam filesystem (Go) ([#23991](https://github.com/apache/beam/issues/23991)). +* Support for SingleStoreDB source added (Java) ([#22617](https://github.com/apache/beam/issues/22617)). Review Comment: Do you mean "SingleStoreDB Source and Sink"? ########## sdks/java/io/singlestore/src/main/java/org/apache/beam/sdk/io/singlestore/SingleStoreUtil.java: ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.sdk.io.singlestore; + +import org.apache.beam.sdk.coders.CannotProvideCoderException; +import org.apache.beam.sdk.coders.Coder; +import org.apache.beam.sdk.coders.CoderRegistry; +import org.apache.beam.sdk.schemas.NoSuchSchemaException; +import org.apache.beam.sdk.schemas.SchemaRegistry; +import org.apache.beam.sdk.values.TypeDescriptor; +import org.apache.beam.sdk.values.TypeDescriptors; +import org.checkerframework.checker.nullness.qual.Nullable; +import org.slf4j.Logger; + +/** Provides utility functions for working with {@link SingleStoreIO}. */ +public class SingleStoreUtil { Review Comment: ```suggestion final class SingleStoreUtil { ``` We may not expose this as public API (as the practice of other IOs) ########## .test-infra/jenkins/job_PerformanceTests_SingleStoreIO.groovy: ########## @@ -0,0 +1,86 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +import CommonJobProperties as common +import Kubernetes +import InfluxDBCredentialsHelper + +String jobName = "beam_PerformanceTests_SingleStoreIO" + +void waitForPodWithLabel(job, Kubernetes k8s, String label) { + job.steps { + shell("${k8s.KUBERNETES_DIR}/singlestore/wait-for-pod-with-label.sh ${label} 600") + } +} + +void waitFor(job, Kubernetes k8s, String resource) { + job.steps { + shell("${k8s.KUBERNETES_DIR}/singlestore/wait-for.sh ${resource} 600") + } +} + +job(jobName) { + common.setTopLevelMainJobProperties(delegate) + common.setAutoJob(delegate,'H H/6 * * *') + common.enablePhraseTriggeringFromPullRequest( + delegate, + 'Java SingleStoreIO Performance Test', + 'Run Java SingleStoreIO Performance Test') + InfluxDBCredentialsHelper.useCredentials(delegate) + + + String namespace = common.getKubernetesNamespace(jobName) + String kubeconfigPath = common.getKubeconfigLocationForNamespace(namespace) + Kubernetes k8s = Kubernetes.create(delegate, kubeconfigPath, namespace) + + k8s.apply(common.makePathAbsolute("src/.test-infra/kubernetes/singlestore/sdb-rbac.yaml")) + k8s.apply(common.makePathAbsolute("src/.test-infra/kubernetes/singlestore/sdb-cluster-crd.yaml")) + k8s.apply(common.makePathAbsolute("src/.test-infra/kubernetes/singlestore/sdb-operator.yaml")) + waitForPodWithLabel(delegate, k8s, "sdb-operator") + + k8s.apply(common.makePathAbsolute("src/.test-infra/kubernetes/singlestore/sdb-cluster.yaml")) + waitFor(delegate, k8s, "memsqlclusters.memsql.com") + + String singlestoreHostName = "LOAD_BALANCER_IP" + k8s.loadBalancerIP("svc-sdb-cluster-ddl", singlestoreHostName) + + Map pipelineOptions = [ + tempRoot : 'gs://temp-storage-for-perf-tests', + project : 'apache-beam-testing', + runner : 'DataflowRunner', + singleStoreServerName : "\$${singlestoreHostName}", + singleStoreUsername : "admin", + singleStorePassword : "secretpass", + singleStorePort: "3306", + numberOfRecords: "100000", Review Comment: Looks like the performance test is passing. The Write then Read steps finishing within seconds. To get a more meaningful metric, ideally the pipeline runs several minutes. How about setting numberOfRecords to 10000000? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
