johnjcasey commented on code in PR #24197:
URL: https://github.com/apache/beam/pull/24197#discussion_r1024110242
##########
sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkEventWriter.java:
##########
@@ -134,12 +156,36 @@ public void setup() {
LOG.info("Disable certificate validation set to: {}", disableValidation);
}
+ // Either user supplied or default enableBatchLogs.
+ if (enableBatchLogs == null) {
+
+ if (enableBatchLogs() != null) {
+ enableBatchLogs = enableBatchLogs().get();
+ }
+
+ enableBatchLogs = MoreObjects.firstNonNull(enableBatchLogs,
DEFAULT_ENABLE_BATCH_LOGS);
+ LOG.info("Enable Batch logs set to: {}", enableBatchLogs);
+ }
+
+ // Either user supplied or default enableGzipHttpCompression.
+ if (enableGzipHttpCompression == null) {
+
+ if (enableGzipHttpCompression() != null) {
Review Comment:
can we not combine 173 - 178?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
